Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Add spring-cloud-dataflow-server to version-info.#5822

Merged
onobc merged 1 commit intospring-attic:mainfrom
corneil:corneil/improve-about-info
May 23, 2024
Merged

Add spring-cloud-dataflow-server to version-info.#5822
onobc merged 1 commit intospring-attic:mainfrom
corneil:corneil/improve-about-info

Conversation

@corneil
Copy link
Contributor

@corneil corneil commented May 21, 2024

This adds an entry to version-info that the UI can display to ensure OSS and PRO UI shows product name and version differently.

In Pro the entry has the following:

    spring-cloud-dataflow-server:
        name: Spring Cloud Dataflow Pro Server

in OSS:

    spring-cloud-dataflow-server:
        name: Spring Cloud Dataflow Server

@corneil corneil requested review from cppwfs and onobc May 21, 2024 13:53
Copy link
Contributor

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corneil I have a couple of comments/questions. Other than that, please remove the bug fix and create separate PR (or at the very least a separate commit describing what the change is).

@corneil corneil force-pushed the corneil/improve-about-info branch from 16a0fff to 3f54653 Compare May 23, 2024 09:44
@onobc onobc self-requested a review May 23, 2024 18:01
Copy link
Contributor

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @corneil

@onobc onobc merged commit bbff654 into spring-attic:main May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants