This repository was archived by the owner on May 14, 2025. It is now read-only.
Migrations for indexes on batch tables#5700
Merged
corneil merged 2 commits intospring-attic:mainfrom Feb 23, 2024
Merged
Conversation
cppwfs
reviewed
Feb 22, 2024
Contributor
cppwfs
left a comment
There was a problem hiding this comment.
Can you provide the reason why we need the optimizations?
.../springframework/cloud/dataflow/server/db/migration/AbstractCreateBatchIndexesMigration.java
Outdated
Show resolved
Hide resolved
.../springframework/cloud/dataflow/server/db/migration/AbstractCreateBatchIndexesMigration.java
Show resolved
Hide resolved
.../springframework/cloud/dataflow/server/db/migration/AbstractCreateBatchIndexesMigration.java
Outdated
Show resolved
Hide resolved
1edac4f to
1157469
Compare
Contributor
Author
Customer experienced queries so long that their ingress requests timed out at 120 or 180s. |
added 2 commits
February 22, 2024 19:54
… queries when customer has large number of job executions in history. They experienced queries exceeding 180s. Fixes spring-attic#5695
Resolve "cannot get connection" in SimpleJobServicePostgresTests, SimpleJobServiceMariadbTests.
1157469 to
d10b086
Compare
Contributor
|
That was fast. Thanks a lot! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrations for indexes on batch tables to improve aggregate view page queries.
Fixes #5695
Also added fix for
SimpleJobServiceMariadbTestsandSimpleJobServicePostgresTestsDO NOT SQUASH Use Rebase & Merge