Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Adding support for sorting by SchemaTarget.#5617

Merged
onobc merged 4 commits intospring-attic:mainfrom
corneil:GH-5615-sort-schema-target
Dec 21, 2023
Merged

Adding support for sorting by SchemaTarget.#5617
onobc merged 4 commits intospring-attic:mainfrom
corneil:GH-5615-sort-schema-target

Conversation

@corneil
Copy link
Contributor

@corneil corneil commented Dec 19, 2023

@corneil corneil marked this pull request as draft December 19, 2023 17:31
@corneil corneil assigned corneil and unassigned cppwfs Dec 19, 2023
@corneil corneil requested a review from cppwfs December 19, 2023 17:32
@corneil corneil marked this pull request as ready for review December 20, 2023 12:42
Copy link
Contributor

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corneil I think your Intellij formatter is not setup correctly (import order issues in the PR).

@corneil corneil requested a review from onobc December 21, 2023 12:54
@corneil
Copy link
Contributor Author

corneil commented Dec 21, 2023

@corneil I think your Intellij formatter is not setup correctly (import order issues in the PR).

Installed spring-java-format for IntelliJ.

Copy link
Contributor

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @corneil - thanks for the updates. Great work!

@onobc onobc merged commit 4ffd30d into spring-attic:main Dec 21, 2023
@corneil corneil deleted the GH-5615-sort-schema-target branch December 22, 2023 09:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Unable to sort tasks by Schema Target

3 participants