Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Fix columns in BOOT3_BATCH_JOB_EXECUTION_PARAMS#5544

Merged
onobc merged 2 commits intospring-attic:mainfrom
onobc:GH-5534-oracle-boot3-schema
Nov 9, 2023
Merged

Fix columns in BOOT3_BATCH_JOB_EXECUTION_PARAMS#5544
onobc merged 2 commits intospring-attic:mainfrom
onobc:GH-5534-oracle-boot3-schema

Conversation

@onobc
Copy link
Contributor

@onobc onobc commented Nov 9, 2023

This commit introduces an Oracle schema migration that updates the BOOT3_BATCH_JOB_EXECUTION_PARAMS table to use the newer Batch5 parameter columns.

I reproduced the bug locally against (with the help of the newly added https://github.com/spring-cloud/spring-cloud-dataflow/wiki/Oracle-on-Mac-ARM64) and then fixed the issue and watched the bug go bye-bye.

Resolves #5534

ℹ️ I created #5545 to add test coverage for this use case.

This commit introduces an Oracle schema migration that updates the
BOOT3_BATCH_JOB_EXECUTION_PARAMS table to use the newer Batch5 parameter
columns.

Resolves spring-attic#5534
@onobc onobc requested a review from cppwfs November 9, 2023 02:47
@klopfdreh
Copy link
Contributor

watched the bug go bye-bye that's what we want! 😄

@onobc onobc merged commit 69e5410 into spring-attic:main Nov 9, 2023
@onobc onobc deleted the GH-5534-oracle-boot3-schema branch November 9, 2023 05:48
@klopfdreh
Copy link
Contributor

Oh a sad smiley - may I excuse myself - just for understanding - I found the way that you described to resolve the bug funny and that’s the reason I answered that way.

Good to see that you also cover ARM!

@onobc
Copy link
Contributor Author

onobc commented Nov 9, 2023

Oh a sad smiley - may I excuse myself - just for understanding - I found the way that you described to resolve the bug funny and that’s the reason I answered that way.

Good to see that you also cover ARM!

Oh no my friend! I am sorry for the confusion... it was meant to be a smiley. I just realized I had picked the wrong emoji (they are tiny on my screen). I get the humor and I like it! Thanks

@klopfdreh
Copy link
Contributor

Happy to hear that. 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Task re-launch fails when using BOOT3 and Oracle

2 participants