This repository was archived by the owner on May 14, 2025. It is now read-only.
Merged
Conversation
Contributor
Author
|
Will add tests in subsequent commit. Want to get this PR in so that the UI side of the feature can progress. |
Contributor
|
Thanks a lot! |
klopfdreh
suggested changes
Sep 4, 2023
| private static final String TASK_EXECUTION_COUNT = "SELECT COUNT(*) FROM " | ||
| + "AGGREGATE_TASK_EXECUTION "; | ||
|
|
||
| private static final String TASK_EXECUTION_COUNT_BEFORE_END_TIME = "SELECT COUNT(*) FROM " |
Contributor
There was a problem hiding this comment.
I guess TASK_EXECUTION_COUNT_BEFORE_END_TIME is not used anymore. So we can remove it.
Contributor
|
Only a small nitpick - everything else looks good to me. Thanks again! 😃 |
dde9503 to
dd38683
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.