Update node examples to use spotify-web-api-node and es6#7
Closed
kauffecup wants to merge 3 commits intospotify:masterfrom
Closed
Update node examples to use spotify-web-api-node and es6#7kauffecup wants to merge 3 commits intospotify:masterfrom
spotify-web-api-node and es6#7kauffecup wants to merge 3 commits intospotify:masterfrom
Conversation
…t-auth-code` script to package.json
…t-client-cred` script
Bontgoy
reviewed
Aug 22, 2017
| const cookieParser = require('cookie-parser'); | ||
| const querystring = require('querystring'); | ||
|
|
||
| const CLIENT_ID = '03ffe0cac0a0401aa6673c3cf6d02ced'; |
There was a problem hiding this comment.
Hi @kauffecup was browsing this repo as well and noticed your PR.
I like the updates but did you mean to leave your credentials in this pull request?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
authorization/app.jsandclient_credentials/app.jsto use the npm modulespotify-web-api-nodeand es6 syntax.I was going through the "Beginner's Guide" which (which links to this repo), and found it would be beneficial to have updated examples using this library and a more modern syntax. It makes the examples more digestible and less complex (and also removed a bunch of lines! woo!)
The client code is untouched and is still fully functional with this updated node code