Skip to content

Conversation

@polac24
Copy link
Collaborator

@polac24 polac24 commented Jun 13, 2023

This is a prework for Xcode 15 support

Up until now, the meta artifact that is was used in all steps (except prebuild) was taken from the artifact's zip. That works, but if a json meta schema changed, we had to invalidate our existing artifacts because the expected json format in postbuild was invalid.

This PR introduces an extra step that after downloading (or reusing already downloaded) artifact, overrides the meta's json to the one that is up to date. By the way, it will remapp all generic paths (like (TARGET_TEMP_DIR)/some.path -> /Actual/Path/To/TargetTempDir/some.path) so other steps don't need to repeat this step.

The main benefit of that are:

  • We will be able to migrate meta json schema without invalidating all existing artifacts
  • xcpostbuild, xcswfitc (and other) wrappers don't have to rewrite paths in the meta

Before

The view of the unzipped artifact in the Intermediates directory

Screenshot 2023-06-12 at 7 32 27 PM

After

Screenshot 2023-06-12 at 7 34 22 PM

@polac24 polac24 marked this pull request as ready for review June 13, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants