Support universal binary framework #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polac24
commented
Mar 7, 2023
| case "-dependency_info": | ||
| dependencyInfo = args[i + 1] | ||
| i += 1 | ||
| case let input where ["", "a"].contains(URL(string: args[i])?.pathExtension): |
Collaborator
Author
There was a problem hiding this comment.
Here is the single line change that this PR introduces. Previously it was,
case let input where input.hasSuffix(".a"):
Collaborator
Author
There was a problem hiding this comment.
To verify that a change would be caught: #186
9d88208 to
8201f77
Compare
polac24
commented
Mar 8, 2023
| 'EXCLUDED_ARCHS' => 'arm64' | ||
| } | ||
| args = ['xcodebuild'] | ||
| args = ['set -o pipefail;', 'xcodebuild'] |
Collaborator
Author
There was a problem hiding this comment.
errors in xcodebuild were not failing a step as args.push("| tee #{LOG_NAME}") was swallowing an error.
acbdev
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for static frameworks with multiple architectures. If a static framework contains multiple architectures, input arguments to
libtooldo not have path extensions (contrary to static libraries, where.ais always used). XCRemoteCache to recognize input files by expecting '.a` extension. To support a case for static frameworks, this PR adds the same behavior where a file with no extension is passed.In this PR, an E2E test to cover a scenario described in #184 is added:
StaticFrameworkis addedStaticFrameworkfor WatchOS simulatorxcodebuildstep. Previously, failedxcodebuildwas not propagated, because| tee ..was swallowing an error.Refactoring&Fix summary:
Fixes #184