Add more bundles for PDE classpath resolving#2673
Merged
hazendaz merged 1 commit intospotbugs:masterfrom Nov 2, 2023
Merged
Conversation
The fix spotbugs#2671 removed a bit more code as needed to fix slow PDE classpath resolving of the PDE project classpath, resulting in "The following classes needed for SpotBugs analysis on project XYZ were missing" warnings reported for few plugin projects. This is a corner case, but not nice. After a bit more evaluation, turned out, we do not need to manually (recursively) resolve plugins classpath looking in each dependent *workspace* PDE bundle (which caused repetitive classpath resolving and huge overhead), but we still need to add all libraries from all *bundle dependencies* (recursive), even if they do not contribute to the project runtime classpath (OSGI does that behind the scenes, so PDE doesn't include them by default). So this patch restores some of that PDE classpath extension logic removed via spotbugs#2671 (but still solves original issue reported in spotbugs#2671). See spotbugs#2671
1 task
hazendaz
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix #2671 removed a bit more code as needed to fix slow PDE classpath resolving of the PDE project classpath, resulting in "The following classes needed for SpotBugs analysis on project XYZ were missing" warnings reported for few plugin projects.
This is a corner case, but not nice.
After a bit more evaluation, turned out, we do not need to manually (recursively) resolve plugins classpath looking in each dependent workspace PDE bundle (which caused repetitive classpath resolving and huge overhead), but we still need to add all libraries from all bundle dependencies (recursive), even if they do not contribute to the project runtime classpath (OSGI does that behind the scenes, so PDE doesn't include them by default).
So this patch restores some of that PDE classpath extension logic removed via #2671 (but still solves original issue reported in #2671).
See #2671
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code