Separate qualifier for new and old sync pks #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildbyte
approved these changes
Aug 14, 2024
Also revise the deterministric UUID generator, since the preiovus one cycled after 16 values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes one pathological scenario, and that is when the changeset contains very small old pks and very large new pks (or vice-versa), such that the whole range basically encompasses all partition files, so we end up re-writing everything.
In addition it fixes a bug whereby the sync base scan does both partition and row pruning, but the former is inclusive (which we want) while the later is exclusive (which we don't). The fix is to use a new API for creating a Delta
TableProviderbased on a particular set of files, which can then be converted toTableSourceto be used in logical planning.