Allow running Seafowl without an object store / catalog config. #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case, Seafowl expects the metastore and the object store settings to be passed to it over the Flight RPC endpoint (when querying or writing) and will error out otherwise. This required some weird refactoring because so many things assume there is a "default" object store and a metastore, so all SeafowlContext methods that want to access the internal default object store for writes now do it through a method that errors out if it's not set up. For the metastore, this change defines an EmptyMetastore that errors if Seafowl actually tries to use it.
mildbyte
commented
Aug 13, 2024
| }, | ||
| cmd @ CreateExternalTable { .. }, | ||
| )) => { | ||
| // Replace the table name with the fully qualified one that has our staging schema |
Contributor
Author
There was a problem hiding this comment.
This was refactored out into prepare_create_external_table without any logic changes
|
So how do I use this, do I simply skip [catalog] part of config? |
gruuya
approved these changes
Aug 13, 2024
Contributor
Author
|
@PJMODOS Yeah, both catalog and object_store can now be skipped completely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, Seafowl expects the metastore and the object store settings to be passed to it over the Flight RPC endpoint (when querying or writing) and will error out otherwise.
This required some weird refactoring because so many things assume there is a "default" object store and a metastore, so all SeafowlContext methods that want to access the internal default object store for writes now do it through a method that errors out if it's not set up. For the metastore, this change defines an EmptyMetastore that errors if Seafowl actually tries to use it.