Refactor object_store_factory and create StorageLocationInfo
#592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-187-storage-location-info
object_store_factory to incorporate MetastoreAgent code for storage location creation
object_store_factory to incorporate MetastoreAgent code for storage location creationobject_store_factory to incorporate MetastoreAgent code for storage location creation
object_store_factory to incorporate MetastoreAgent code for storage location creationobject_store_factory and create StorageLocationInfo
object_store_factory and create StorageLocationInfoobject_store_factory and create StorageLocationInfo
gruuya
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
object_store_factorywith the changes:allow_httpandskip_signaturetoS3Config;build_object_store(ObjectStoreConfig)to be a implementation ofObjectStoreConfig.StorageLocationInfowith the methodbuild_storage_location_info.