Use the storage location name as the key in the clade schema #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| message TableObject { | ||
| string name = 1; | ||
| // Path within the provided storage location, if any | ||
| string path = 2; |
Collaborator
There was a problem hiding this comment.
I know we don't care about backwards compatibility here, but should we try to follow Protobuf guidelines on field number assignment?: https://protobuf.dev/programming-guides/proto3/#assigning . This could help make errors clearer in case of a server/client protocol mismatch.
Specifically:
- NewProtocol.TableObject.store seems like a distinct field from OldProtocol.TableObject.location, so should use a new field number
- NewProtocol.StorageLocation.location seems like the same field as OldProtocol.StorageLocation.location, so should stay as field number 1
- NewProtocol.StorageLocation.options seems like the same field as OldProtocol.StorageLocation.options, so should stay as field number 2
src/catalog/metastore.rs
Outdated
| &self, | ||
| table: TableObject, | ||
| store_options: &HashMap<String, HashMap<String, String>>, | ||
| store_options: &HashMap<String, (String, HashMap<String, String>)>, |
Collaborator
There was a problem hiding this comment.
There's 4 Strings in this type and it wasn't clear on first reading what each of them is. Maybe add a comment about this?
SergeiPatiakin
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As opposed to keying them via their root URL.