Make origin a string #548
Merged
Make origin a string #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eatonphil
commented
Jun 26, 2024
mildbyte
reviewed
Jul 1, 2024
Co-authored-by: Artjoms Iskovs <mildbyte@gmail.com>
Co-authored-by: Artjoms Iskovs <mildbyte@gmail.com>
Collaborator
Author
|
Feel free to squash and merge this too if it is approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vadim and Petr have suggested another value I use that will be a string. Since I'm the one that dissuaded us from doing that in the first place, I have offered up a partial attempt at reverting this to what Marko originally implemented.
I have some questions about the tests though. I'm also not sure how to build the protos? I can't see how we do that in CI or anything.