Upgrade to DataFusion 39 #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildbyte
approved these changes
Jun 20, 2024
| Ok(()) | ||
| } | ||
|
|
||
| // XXX SEAFOWL: removed the struct definitions here because we want to use |
Contributor
There was a problem hiding this comment.
I forgot we keep having to pull DF's parser changes and rebase ours on top of them, does DF still not have hooks to extend the parser?
Contributor
Author
There was a problem hiding this comment.
Yes I meant to look into that, but didn't.
Looks like it's easier now, but still some methods are just private so we'd still need to copy most of the stuff.
Co-authored-by: Artjoms Iskovs <artjoms.iskovs@enterprisedb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bump Arrow to v52.