Improve Arrow Flight SQL interface logging #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildbyte
approved these changes
Apr 19, 2024
src/frontend/flight/handler.rs
Outdated
Comment on lines
65
to
72
| let plan = ctx | ||
| .plan_query(query) | ||
| .await | ||
| .inspect_err(|err| debug!("Error planning query id {query_id}: {err}"))?; | ||
| let batch_stream = ctx | ||
| .execute_stream(plan) | ||
| .await | ||
| .inspect_err(|err| debug!("Error executing query id {query_id}: {err}"))?; |
Contributor
There was a problem hiding this comment.
These could be INFO I think (since we can't turn on debug logging on the fly without redeploying Seafowl)
src/frontend/flight/handler.rs
Outdated
| "No results found for query id {query_id}" | ||
| )))?; | ||
| let (_, batch_stream_mutex) = self.results.remove(query_id).ok_or_else(|| { | ||
| debug!("No results found for query id {query_id}"); |
Contributor
There was a problem hiding this comment.
Should be an INFO/ERROR? If a client is requesting a query that it thought we were executing but we aren't, we definitely want to know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log query ids, request metadata as well as errors.