Move Delta store creation into a separate ObjectStoreFactory #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The factory makes sure that object_store clients are only built once (using the URL and options as the key, no expiry) instead of on every call. This means that the cached data from the same object store will be shared across several queries and won't get reset.
gruuya
approved these changes
Apr 17, 2024
|
|
||
| pub struct ObjectStoreFactory { | ||
| default_store: Arc<InternalObjectStore>, | ||
| custom_stores: RwLock<HashMap<StoreCacheKey, Arc<dyn ObjectStore>>>, |
Contributor
There was a problem hiding this comment.
Let's consider doing this, though we can do it in a follow-up PR.
Suggested change
| custom_stores: RwLock<HashMap<StoreCacheKey, Arc<dyn ObjectStore>>>, | |
| custom_stores: DashMap<StoreCacheKey, Arc<dyn ObjectStore>>, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The factory makes sure that object_store clients are only built once (using the URL and options as the key, no expiry) instead of on every call. This means that the cached data from the same object store will be shared across several queries and won't get reset.