Skip to content

Improve caching object store performance #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gruuya merged 4 commits into from
Mar 11, 2024
Merged

Improve caching object store performance #507

gruuya merged 4 commits into from
Mar 11, 2024

Conversation

@gruuya
Copy link
Contributor

@gruuya gruuya commented Mar 8, 2024 •
edited
Loading

List of improvements:

  • move out the writing of data to disk to a separate task
  • and remove the lock on the file manager
  • but let all the incoming calls for the requested range use the in-memory bytes until the write completes
  • finally, change moka eviction policy to LRU

Tested on local minio using ClickBench q19, seems to improve against both old-cache and no-cache setups.

@gruuya gruuya requested a review from mildbyte March 8, 2024 13:08
@gruuya gruuya force-pushed the cache-write-task branch from e2e75a2 to a375874 Compare March 8, 2024 15:13
@gruuya gruuya merged commit 71306b2 into main Mar 11, 2024
@gruuya gruuya deleted the cache-write-task branch March 11, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mildbyte mildbyte mildbyte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gruuya @mildbyte