Replace log with tracing
#493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildbyte
approved these changes
Jan 24, 2024
| builder | ||
| .parse_filters( | ||
| env::var(env_logger::DEFAULT_FILTER_ENV) | ||
| .unwrap_or_else(|_| "sqlx=warn,info".to_string()) |
Contributor
There was a problem hiding this comment.
think there was a reason for this sqlx default (it's too spammy by default or vice versa, don't remember)
Contributor
Author
There was a problem hiding this comment.
Yeah seems like it was to spammy: 398b994
However I'm not seeing this anymore (nothing appears by default on INFO level).
675d2e3 to
b364ebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enable JSON logging, closes #492.
Couple of follow-ups:
The default logger swallows up the target from libraries that are using plainlogwhen converting them to tracing events, which obfuscates the source of those messages. They're still available in the JSON output in thefields.log.targetfield. Opened Enable overridingtargetfield withlog's target inLogTracertokio-rs/tracing#2862 for that.