Skip to content

Implement streaming of result rows #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gruuya merged 2 commits into from
May 31, 2023
Merged

Implement streaming of result rows #424

gruuya merged 2 commits into from
May 31, 2023

Conversation

@gruuya
Copy link
Contributor

@gruuya gruuya commented May 31, 2023 •
edited
Loading

This is so as to avoid accumulating the entire result in memory and potentially OOM-ing the process. Closes #258

Example, using a large table to perform SELECT * ... LIMIT 100000:

  • W/O streaming memory peaks at 220MB (current main)
    slika

  • W/ streaming memory peaks at 30MB (this PR)
    slika

@gruuya gruuya requested a review from mildbyte May 31, 2023 10:37
@gruuya gruuya merged commit 30ce4af into main May 31, 2023
@gruuya gruuya deleted the stream-json-results branch May 31, 2023 12:15
@gruuya gruuya mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mildbyte mildbyte mildbyte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prevent full table scans that result in OOM

3 participants

@gruuya @mildbyte