BUG Checks if filenames have space#636
Merged
lucyleeow merged 4 commits intosphinx-gallery:masterfrom Mar 31, 2020
Merged
Conversation
choldgraf
approved these changes
Mar 31, 2020
larsoner
approved these changes
Mar 31, 2020
Contributor
larsoner
left a comment
There was a problem hiding this comment.
Thanks @lucyleeow, please merge once CIs are happy
Contributor
Author
|
Happy to close the issue #440 or keep it open? |
Contributor
|
Yeah feel free to close once merged / add magic words to this PR |
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
==========================================
+ Coverage 97.7% 97.71% +0.01%
==========================================
Files 31 31
Lines 3177 3194 +17
==========================================
+ Hits 3104 3121 +17
Misses 73 73
Continue to review full report at Codecov.
|
Contributor
Author
|
Thanks for the reviews @larsoner and @choldgraf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #440
Not a fan of spaces in filenames so I think the warning is adequate.