ENH: Show memory usage, too#523
Merged
larsoner merged 6 commits intosphinx-gallery:masterfrom Aug 12, 2019
Merged
Conversation
Contributor
Author
|
Example output currently, for and for SG: And the HTML file, courtesy CircleCI: https://969-25860190-gh.circle-artifacts.com/0/rtd_html/auto_examples/sg_execution_times.html Looks like AppVeyor is broken on |
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
==========================================
+ Coverage 96.25% 96.63% +0.37%
==========================================
Files 29 29
Lines 2695 2731 +36
==========================================
+ Hits 2594 2639 +45
+ Misses 101 92 -9
Continue to review full report at Codecov.
|
Contributor
Author
|
@choldgraf this one should be good to go. We can improve aesthetics in subsequent PRs if people are motivated, but they are already a nice upgrade. |
Contributor
|
@banesullivan have you given this one a chance? |
Contributor
Author
|
Here is the output on CircleCI for MNE: Details |
Contributor
|
@choldgraf - I haven't given it a try yet, apologies! I'll try experimenting with it today! |
Contributor
|
@banesullivan sounds good - once I get a 👍 from you then I think we should merge, please feel free to give a code review as well! |
Contributor
Author
|
... and for Given it works on each of these repos I'll go ahead and merge @banesullivan. We can always iterate in subsequent PRs if we want to tweak things! |
Contributor
|
Thanks, @larsoner and apologies for not getting around to this! I'll iterate back when I have free time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #522.
@banesullivan feel free to try it and open a PR into my branch with any aesthetic tweaks you want (e.g., a header).