Codecov Report

Merging #475 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
+ Coverage   96.28%   96.29%   +0.01%     
==========================================
  Files          29       29              
  Lines        2636     2647      +11     
==========================================
+ Hits         2538     2549      +11     
  Misses         98       98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83ea1ac...fd7f303. Read the comment docs.

Can you add a small test to test_gen_rst.py that would fail on master but pass on this PR?

Is there any case, where stripping is neccessary?

I would worry that an indentation of the first line could be interpreted as the intended indentation "level" for the code block. But maybe as long as they are all indented by at least 4 spaces (as they will be) it won't matter if the first one is indented by, say, 8 spaces. Have you tried it / does it work?

If it doesn't, there is probably some RST trick to make it work.

One way it probably won't is if there is only a single line, and there is starting whitespace. In this case, we could probably do something fancy with unicode spacing to force it to actually space it out, but this might be overkill.

I added the requested test.

I would worry that an indentation of the first line could be interpreted as the intended indentation "level" for the code block. But maybe as long as they are all indented by at least 4 spaces (as they will be) it won't matter if the first one is indented by, say, 8 spaces. Have you tried it / does it work?

I tested this and I found that this is not a problem.

One way it probably won't is if there is only a single line, and there is starting whitespace. In this case, we could probably do something fancy with unicode spacing to force it to actually space it out, but this might be overkill.

I think indentation for a single output line is not necessary, since indentation is usually used to align multiple lines to each other.

Could you have a look, what went wrong here? The failure is in test_full.py, a file that I have not touched and seems to happen on Windows at Python 2.7 only. I do not quite understand how my added test caused this error.

Thanks @padix-key !