Closed
Conversation
This allows Sphinx-Gallery to be build by a direct call to sphinx-build, specifying the sources directory and the build output directory. There is no more the constrain to launch the build from the makefile is the sources directory. - Correct relative path when embedding links - Correct path during build - Summary of failing examples to work on relative path builds - Update tests - Update docs clean and build configs
New modules - execute blocks - save images - write rst review image test Load Agg in execute_blocks.py because tests load order is alphabetic
Member
|
Wow kudos for the effort ! I thought I commented on the issue but apparently not, I'll do that in a few minutes. |
Author
|
Closing and opening another branch #197 with fixed commit history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Titan-C,
Following discussion #194, I've made a working version with support for multiple languages. In the process, I've done quite a bit of refactoring.
I also
_to function names.What I've done was I've forked
func_rstbranch of your fork from #160 and added my commits. Unfortunately, you've made the top few commits in your branch obsolete since my fork, probably usingcommit --amend / squashandpush --force. There is a bug (:overflow:being visible in gallery page) which you've fixed, but I couldn't merge these changes easily because of the above :(For further commits you add to #160, please add your commits one by one rather than modifying existing commits. We can rebase/package these commits into 1 after PR is ready to merge.
Please have a look at the implementation and give me your feedback.
Right now, I've written only lua parser, adding other languages shouldn't be hard at this point.
TODO: