MNT Add test for _bool_eval and add configs to _bool_eval check#1442
Merged
larsoner merged 4 commits intosphinx-gallery:masterfrom Feb 28, 2025
Merged
MNT Add test for _bool_eval and add configs to _bool_eval check#1442larsoner merged 4 commits intosphinx-gallery:masterfrom
_bool_eval and add configs to _bool_eval check#1442larsoner merged 4 commits intosphinx-gallery:masterfrom
Conversation
_bool_eval_bool_eval and add configs to _bool_eval check
lucyleeow
commented
Feb 27, 2025
| your ``Makefile`` with: | ||
| website to display, or any use you can imagine for it. | ||
|
|
||
| This can be done by setting the ``plot_gallery`` configuration in the |
Contributor
Author
There was a problem hiding this comment.
This was a more opinionated change, to talk about the makefile second, but I thought it was more consistent with the rest of the docs which generally talk about setting the conf in the conf.py file first
larsoner
reviewed
Feb 27, 2025
Contributor
larsoner
left a comment
There was a problem hiding this comment.
Just one idea / question about a comment update
| # XXX anything that can only be a bool (rather than str) should probably be | ||
| # evaluated this way as it allows setting via -D on the command line | ||
| for key in ( | ||
| "download_all_examples", |
Contributor
There was a problem hiding this comment.
Can we get rid of the XXX comment above now that you've made these changes?
Contributor
Author
There was a problem hiding this comment.
Good idea, I've amended the comment just to remind us why we are doing the _bool_eval
Contributor
|
Thanks @lucyleeow ! |
This was referenced Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1411
_bool_eval_bool_evalcheck-Dbuild option, as long as it is one of the accepted types by-D. As we now accept callables as string path to object, I think these can now also be set via-D.