Fix: Fix minigallery duplicates#1430
Merged
larsoner merged 15 commits intosphinx-gallery:masterfrom Feb 7, 2025
Merged
Conversation
6c0f78f to
3f3b7b4
Compare
for more information, see https://pre-commit.ci
Contributor
|
|
lucyleeow
commented
Feb 4, 2025
Contributor
Author
There was a problem hiding this comment.
Test failures fixed, sorry I just didn't have the time, last week, to get this PR to review state.
More tests to be added (and I've got to amend the minigallery docs), but I just wanted to check with you @larsoner, that you're happy with how this is looking?
|
|
||
| def _thumbnail_div( | ||
| target_dir, src_dir, fname, snippet, title, is_backref=False, check=True | ||
| target_dir, src_dir, fname, intro, title, is_backref=False, check=True |
Contributor
Author
There was a problem hiding this comment.
intro makes it consistent with the term that is used everywhere else in the code
| Path( | ||
| gallery_conf["src_dir"], | ||
| gallery_conf["backreferences_dir"], | ||
| "backreferences_all", |
Contributor
Author
There was a problem hiding this comment.
Not 100% on naming file backreferences_all.json , happy to take suggestions
larsoner
reviewed
Feb 4, 2025
lucyleeow
commented
Feb 5, 2025
larsoner
approved these changes
Feb 7, 2025
Contributor
larsoner
left a comment
There was a problem hiding this comment.
Looks good, thanks @lucyleeow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1259
closes #1414
.examplesfiles are still generated as before, no changes there