FIX generate zipfiles when index passed by user#1353
FIX generate zipfiles when index passed by user#1353larsoner merged 4 commits intosphinx-gallery:masterfrom
Conversation
| "auto_examples_README_header", | ||
| "auto_examples_rst_index", | ||
| "auto_examples_with_rst", |
There was a problem hiding this comment.
Noticed these were missing, doesn't affect tests but I think if someone is running locally, prevents test copying over previously generated gallery files
for more information, see https://pre-commit.ci
|
@QuLogic thanks, your fix was perfect. Do you need a patch release quickly or are you happy to wait a few days, to wait and see if we broke other things? |
|
@lucyleeow I would say it's worth making a quick point release |
I am eager to try out some of the new features, but we are not close to a release, I think, so there's no current rush, and could wait a week or two. |
|
@larsoner do you think we should wait a few days (sphinx 8.0 has just been released too) or release now? |
|
We already test against Sphinx dev so hopefully we're safe there. My vote is to release now but it depends on how much extra work it creates. |
… to version 0.17.1 v0.17.1 ------- **Fixed bugs:** - FIX: Fix stability of stored compiled regex `#1369 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1369>`__ (`larsoner <https://github.com/larsoner>`__) - ENH: Improve \_sanitize_rst `#1366 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1366>`__ (`timhoffm <https://github.com/timhoffm>`__) - Obey prefer_full_module setting when finding backreferences `#1364 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1364>`__ (`QuLogic <https://github.com/QuLogic>`__) - Fix linking to class attributes with prefer_full_module `#1363 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1363>`__ (`QuLogic <https://github.com/QuLogic>`__) - Improve minigallery directive path input resolution `#1360 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1360>`__ (`lucyleeow <https://github.com/lucyleeow>`__) - FIX Allow str path minigallery entries when backreferences off `#1355 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1355>`__ (`lucyleeow <https://github.com/lucyleeow>`__) - FIX generate zipfiles when index passed by user `#1353 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1353>`__ (`lucyleeow <https://github.com/lucyleeow>`__) **Documentation** (NEWS truncated at 15 lines)
Fixes #1332 (comment)
When top level index.rst is passed by user we were not generating the zipfiles.