[NO MRG - WIP] Improved use of relative paths#133
Closed
Titan-C wants to merge 5 commits intosphinx-gallery:masterfrom
Closed
[NO MRG - WIP] Improved use of relative paths#133Titan-C wants to merge 5 commits intosphinx-gallery:masterfrom
Titan-C wants to merge 5 commits intosphinx-gallery:masterfrom
Conversation
Since build can only be triggered from the documentation source a quick fix was established to move to this directory when sphinx-gallery runs. On this first step I declare the directories from the information provided by sphinx. Still it does not work fully for retrieving images
Member
Author
|
Closing in favor of #190 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to fix in a broader sense issues #40 #50 #115 #119 #120
The issue is that, sphinx-gallery (sphinx way of work) relies on relative paths within the documentation to resolve correctly the back reference links and thumbnail images from arbitrary location in the documentation source.
If one is to build the documentation not inside the doc source using the
make htmlcommand one runs into problems. PR #119 addresses this issue by changing directory during build. But this solution neglects the link embedding in the final html.This should not be merged before #97