Skip to content

[pre-commit.ci] pre-commit autoupdate#1328

Merged
larsoner merged 2 commits intomasterfrom
pre-commit-ci-update-config
Jun 18, 2024
Merged

[pre-commit.ci] pre-commit autoupdate#1328
larsoner merged 2 commits intomasterfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci
Copy link
Copy Markdown
Contributor

@pre-commit-ci pre-commit-ci bot commented Jun 17, 2024

@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
0f27f1b 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.8 → v0.4.9](astral-sh/ruff-pre-commit@v0.4.8...v0.4.9)
@lucyleeow
Copy link
Copy Markdown
Contributor

lucyleeow commented Jun 18, 2024

Doc build failing due to pyvista not supporting numpy 2.0.

    Traceback (most recent call last):
      File "/home/circleci/project/pyvista_examples/plot_collisions.py", line 54, in <module>
        pl.add_mesh(sphere0, show_scalar_bar=False, cmap="bwr")
      File "/home/circleci/python_env/lib/python3.10/site-packages/pyvista/plotting/plotter.py", line 3556, in add_mesh
        self.mapper.set_scalars(
      File "/home/circleci/python_env/lib/python3.10/site-packages/pyvista/plotting/mapper.py", line 666, in set_scalars
        scalars = scalars.astype(np.float_)
      File "/home/circleci/python_env/lib/python3.10/site-packages/numpy/__init__.py", line 397, in __getattr__
        raise AttributeError(
    AttributeError: `np.float_` was removed in the NumPy 2.0 release. Use `np.float64` instead.. Did you mean: 'float16'?

I see you (@larsoner) fixed in pyvista/pyvista#5460 but I can't tell if this has been included in a release?

@larsoner
Copy link
Copy Markdown
Contributor

larsoner commented Jun 18, 2024

It hasn't been released yet: PyTables/PyTables#1083

I'll push a commit to hopefully fix it

@larsoner larsoner enabled auto-merge (squash) June 18, 2024 14:07
@larsoner larsoner merged commit 3db16d4 into master Jun 18, 2024
@larsoner larsoner deleted the pre-commit-ci-update-config branch June 18, 2024 14:16
@lucyleeow
Copy link
Copy Markdown
Contributor

lucyleeow commented Jun 18, 2024

Thanks @larsoner ! I'll think I'll make an issue to remind us to revert back to release once pyvista supports numpy 2.0.

Also I am confused about: PyTables/PyTables#1083 was this the right link?

@lucyleeow lucyleeow mentioned this pull request Jun 18, 2024
Closed
@larsoner
Copy link
Copy Markdown
Contributor

larsoner commented Jun 19, 2024

Argh no that was a different NumPy 2.0 issue. Looks like https://github.com/pyvista/pyvista/releases/tag/v0.43.10 is out with 2.0 compat so probably okay already!

@lucyleeow
Copy link
Copy Markdown
Contributor

lucyleeow commented Jun 19, 2024

hmm I don't think 0.43.10 has pyvista/pyvista#5460 though there is pyvista/pyvista#6156

Also CI fail: #1331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucyleeow @larsoner