Oh CIs are unhappy, looks like there are still some references to dev-requirements. Maybe git grep can help here

@larsoner Thanks for the speedy review! I see that CI needed dev-requirements.txt . I will look into telling CI to install using the dev option.

Okay let me know whenever you need me to approve CIs. GH is going to ask on every commit you push as a new contributor 😬

I looked at.github/install.sh . There are a lot of possible combinations of installed dependencies. Do they still work as intended since the migration to pyproject.toml? It seems pip would install dependencies even for cases where that is not intended, such as minimal. It would be nice if there were at least comments explaining all of the variants.

Yeah it is not super well documented. Want me to try pushing a commit?

In short I would try changing any instance of dev-requirements.txt install to later pip install .[dev] or so, and otherwise leave the existing combinations alone.

@larsoner feel free to try that.

Alternatively, I think that,

PIP_DEPENDENCIES=`python -c 'import tomllib; data = tomllib.load(open("pyproject.toml", "rb")); print(" ".join(data["project"]["optional-dependencies"]["dev"]))'``

is the most one-for-one comparable to the -r requirements-dev.txt.

You would know better than I would which is the better approach.

I'm also not sure if it's better to include --no-build-isolation in
python -m pip install --editable --no-build-isolation ".[dev]"

Thanks @AlexSzatmary ! I went with the minimalist approach in 4178d84 of just replacing the -r with equivalent [...] in the eventual install line. That way we can leave refactoring for later. Though I think in principle we maybe had all those variants for a reason at some point, so probably not worth it for now!

Awesome, thanks @larsoner !