MNT: Turn the block tuple into a namedtuple#1303
MNT: Turn the block tuple into a namedtuple#1303larsoner merged 4 commits intosphinx-gallery:masterfrom
Conversation
for more information, see https://pre-commit.ci
|
Not quite sure what the failing test for 3.11 / pip mean. Could anybody hint at whether they are related to this PR or whether that pipeline is broken for other reasons? Thanks. |
|
I couldn't replicate locally, the rerun timing check has always been a bit brittle but no idea why I think |
|
Seems spurious, passing now |
|
I think we have to update |
|
Code-wise this is good to go. It's only documentation that could/should be improved. There are a number of places still describing I'm a bit tight with time now, so it would take a bit until I get around updating the docs as well. If you want to take this as is or update the docs yourself, that would also be very welcome. |
|
Done, @larsoner feel free to merge. |
|
Thanks @timhoffm @lucyleeow ! |
It's better to give the "Block" concept its own entity and thus be able to access it's attributes by name.
I anticipate that I will need to expand the Block data to support per-block options for #1283, and that expansion will be simpler when blocks are no longer pure tuples. I've decided to split this out for simpler review and advertise this PR as code cleanup.