Remove leftover config checking of image_srcset#1278
Merged
larsoner merged 2 commits intosphinx-gallery:masterfrom Apr 1, 2024
Merged
Remove leftover config checking of image_srcset#1278larsoner merged 2 commits intosphinx-gallery:masterfrom
image_srcset#1278larsoner merged 2 commits intosphinx-gallery:masterfrom
Conversation
Contributor
Author
|
@larsoner AFAICT your comment from #808 (comment) is still relevant for this config:
? This isn't in the docs, but I think it should be added if it is relevant? |
Contributor
|
We dropped Mayavi support in #1090 so I think that comment isn't as relevant anymore. Changes LGTM, thanks @lucyleeow ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
image_srcsetconfig added in #808. Originally in that PR an empty string was meant to mean save the usual image: #808 (comment). Later on we changed it to never neededing the empty string: #808 (comment)This removes the redundant config checking as
image_srcsetshould not be taking an empty string.First noticed: https://github.com/sphinx-gallery/sphinx-gallery/pull/1241/files#r1542174678