ci: simplify check-type-label [wip]#1270
Closed
Borda wants to merge 9 commits intosphinx-gallery:masterfrom
Closed
ci: simplify check-type-label [wip]#1270Borda wants to merge 9 commits intosphinx-gallery:masterfrom
Borda wants to merge 9 commits intosphinx-gallery:masterfrom
Conversation
Contributor
|
This does not appear to work: |
Borda
commented
Mar 11, 2024
Contributor
Author
|
@larsoner changed to another action which seems to be working fine 🦩 |
larsoner
reviewed
Mar 11, 2024
Contributor
Author
|
Well, it seems that neither I hoped worked correctly, and the last option I found is based on dockers, which I am not familiar with, so let's leave this as it is... |
Contributor
|
Okay, feel free to improve the error message if you think it would help though! Can be part of another PR like the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just marginal readability simplification...
On the other hand, thinking about how to play with this check since it seems to bring some confusion for external/forked PRs. I fully understand and agree with the purpose, just adding some context/ my perception as a contributor... I came to create a PR, and I have many different projects I usually just see the aggregated list, and on the list, I tend to re-visit PRs with some failing checks to make them 🟢 so to know all is fine on my side and could be processed further. But in this case, I will always have this check 🟥 until a maintainer adds a label...