Skip to content

ci: associate install.sh with used job#1265

Merged
larsoner merged 3 commits intosphinx-gallery:masterfrom
Borda:ci/install
Mar 8, 2024
Merged

ci: associate install.sh with used job#1265
larsoner merged 3 commits intosphinx-gallery:masterfrom
Borda:ci/install

Conversation

@Borda
Copy link
Copy Markdown
Contributor

@Borda Borda commented Mar 7, 2024

This is just a minor cleaning to reduce root structure.
The install.sh is used in a single place in GH actions. I would suggest moving it to the same folder.

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense now that we are only using GH actions. I'll let @larsoner merge as he's more familiar with the CIs.

Thanks @Borda !

Copy link
Copy Markdown
Contributor

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Borda

@larsoner larsoner merged commit 3b750e5 into sphinx-gallery:master Mar 8, 2024
@Borda Borda deleted the ci/install branch March 11, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants