ENH: Always write sg_execution_times and make DataTable#1198
Merged
larsoner merged 12 commits intosphinx-gallery:masterfrom Sep 22, 2023
Merged
ENH: Always write sg_execution_times and make DataTable#1198larsoner merged 12 commits intosphinx-gallery:masterfrom
larsoner merged 12 commits intosphinx-gallery:masterfrom
Conversation
Contributor
Author
|
Okay I also made it much more usable by injecting some JS and scoped CSS to make it a DataTable. I've always wanted to be able to sort by computation time or memory usage and now I can! And it comes with nice stuff like pagination and search for free: |
Contributor
Author
|
@lucyleeow ready for review/merge from my end |
lucyleeow
approved these changes
Sep 22, 2023
Contributor
lucyleeow
left a comment
There was a problem hiding this comment.
the datatable looks great!
Contributor
Author
|
Thanks @lucyleeow pushed a commit to update the comments and marking for merge when green |
clrpackages
referenced
this pull request
in clearlinux-pkgs/pypi-sphinx_gallery
Nov 28, 2023
… to version 0.15.0 v0.15.0 ------- Support for Python 3.7 dropped in this release. Requirement is now Python >=3.8. Pillow added as a dependency. **Implemented enhancements:** - ENH: Improve logging visibility of errors and filenames `#1225 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1225>`__ (`larsoner <https://github.com/larsoner>`__) - ENH: Improve API usage graph `#1203 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1203>`__ (`larsoner <https://github.com/larsoner>`__) - ENH: Always write sg_execution_times and make DataTable `#1198 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1198>`__ (`larsoner <https://github.com/larsoner>`__) - ENH: Write all computation times `#1197 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1197>`__ (`larsoner <https://github.com/larsoner>`__) - ENH: Support source files in any language `#1192 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1192>`__ (`speth <https://github.com/speth>`__) - FEA Add examples recommender system `#1125 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1125>`__ (`ArturoAmorQ <https://github.com/ArturoAmorQ>`__) (NEWS truncated at 15 lines)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MNE-Python we only execute examples that have been changed. I'd like to link CircleCI artifacts redirector action to
sg_execution_times.htmtl, but this only exists if any examples have been executed. It's easy enough to just always write this file (the cost is very low), so I figure we might as well do it.