MAINT Move figure_rst path testing to own unit test#1173
Merged
larsoner merged 4 commits intosphinx-gallery:masterfrom Aug 18, 2023
Merged
MAINT Move figure_rst path testing to own unit test#1173larsoner merged 4 commits intosphinx-gallery:masterfrom
figure_rst path testing to own unit test#1173larsoner merged 4 commits intosphinx-gallery:masterfrom
Conversation
larsoner
reviewed
Aug 17, 2023
| # test issue #229 | ||
| local_img = [os.path.join(os.getcwd(), "third." + ext)] | ||
|
|
||
| def test_figure_rst_path(): |
Contributor
There was a problem hiding this comment.
I think we still want this, right?
Suggested change
| def test_figure_rst_path(): | |
| @pytest.mark.parametrize("ext", _KNOWN_IMG_EXTS) | |
| def test_figure_rst_path(): |
larsoner
reviewed
Aug 17, 2023
| local_img = [os.path.join(os.getcwd(), "third.png")] | ||
| image_rst = figure_rst(local_img, ".") | ||
|
|
||
| single_image = SG_IMAGE % ("third." + ext, "", "/third." + ext) |
Contributor
There was a problem hiding this comment.
... then you'll need to revert this
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test one thing in
test_figure_rst. Remove path testing to separate test.