Merged
Conversation
Closed
lucyleeow
reviewed
Aug 15, 2023
Comment on lines
+24
to
+28
| #- repo: https://github.com/adrienverge/yamllint.git | ||
| # rev: v1.32.0 | ||
| # hooks: | ||
| # - id: yamllint | ||
| # args: [--strict, -c, .yamllint.yml] |
Contributor
There was a problem hiding this comment.
Was this meant to be uncommented or removed?
Contributor
Author
There was a problem hiding this comment.
In a follow up PR I uncommented it, made the necessary changes, merged, then added that commit to revs-ignore because it just indented some stuff more
Contributor
There was a problem hiding this comment.
Ah sorry did not see that, thanks for replying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should come back green. Follow-up commit will uncomment the yamllint and fix the errors, then another to add the squash-and-merged commit to revs-ignore.
Running
ruffandcodespellon the entire codebase found some legitimate stuff. At some point it would be nice to have a (much) shorter ignore list for the docstring stuff, but that can be done later if someone gets bored.