Merged
Conversation
Contributor
|
Nitpick, maybe we could add to our readme.rst under the 'contributing' section what version of black we use for the code. Just so it's documented somewhere since different versions can format differently. Does not have to be in this PR. |
Contributor
Author
|
Not sure it's worth it with precommit.ci, it'll get out of date fairly often (and we'll have to update it) and if someone happens to use the wrong/older version that didn't format the same the CI will automatically push fixes |
Contributor
|
Yeah good point, sorry missed that we are doing pre-commit. I'm not used to that actually! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step in #1162 -- run
black .. One file fails but it has a SyntaxError so this is expected.I'll mark this for merge-when-green, then open a follow-up PR that does the rest of what's required for #1162:
blackto pre-commitruffto pre-commit