Add LICENSE and tests using flit#44
Add LICENSE and tests using flit#44apraga wants to merge 1 commit intosphinx-doc:mainfrom apraga:main
Conversation
| long_description=long_description, | ||
| long_description_content_type="text/markdown", | ||
| url="https://github.com/wpilibsuite/sphinxext-opengraph", | ||
| license="LICENSE.md", |
There was a problem hiding this comment.
Isn't this inconsistent with renaming from LICENSE.md to LICENSE
There was a problem hiding this comment.
Indeed, it's a leftover from an earlier version (it's the first time I have to create a python package)
|
Thanks for the PR and intention to package this project for FreeBSD! Not including the license is an omission and should be included. However, I don't think that tests should be included. Our testing only dependencies shouldn't be required to use the project. Additionally, hardcoding the version isn't a good idea for us as we could forget to change it. If we do want to include the version, it would probably have to be generated, either in setup.py or in the CI. |
|
Hi, |
|
Can you not package it directly from the source code? |
|
It is possible, and that's what I did as a temporary workaround. However, using standard Python ecostystem (PyPi) is the method of choice, unless there is a compelling reason not to. |
Hi,
Currently, the package on pypi does not have a LICENSE nor tests. As I'm creating a port for FreeBSD, those would be very valuable. I've taken the liberty to use
flitto correct that.Thanks,