Skip to content

py domain: Add py:property directive to describe a property (refs: #7068)#7298

Merged
tk0miya merged 1 commit intosphinx-doc:masterfrom
tk0miya:7068_pyproperty_directive
Mar 13, 2021
Merged

py domain: Add py:property directive to describe a property (refs: #7068)#7298
tk0miya merged 1 commit intosphinx-doc:masterfrom
tk0miya:7068_pyproperty_directive

Conversation

@tk0miya
Copy link
Copy Markdown
Member

@tk0miya tk0miya commented Mar 11, 2020

Feature or Bugfix

  • Feature
  • Refactoring

Purpose

@tk0miya tk0miya added type:enhancement enhance or introduce a new feature domains:py internals:refactoring labels Mar 11, 2020
@tk0miya tk0miya added this to the 3.0.0 milestone Mar 11, 2020
@tk0miya tk0miya force-pushed the 7068_pyproperty_directive branch from f632dd3 to 7a3c1e3 Compare March 11, 2020 15:59
@tk0miya tk0miya mentioned this pull request Mar 11, 2020
Closed
tk0miya
tk0miya commented Mar 11, 2020
View reviewed changes
@tk0miya tk0miya force-pushed the 7068_pyproperty_directive branch 2 times, most recently from 7f68d78 to 495cb14 Compare March 11, 2020 16:52
@tk0miya tk0miya closed this Mar 12, 2020
@tk0miya tk0miya deleted the 7068_pyproperty_directive branch March 22, 2020 06:38
flying-sheep
flying-sheep reviewed Mar 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes to address the concerns raised in #7068

@tk0miya tk0miya restored the 7068_pyproperty_directive branch April 22, 2020 17:13
@tk0miya tk0miya reopened this Apr 27, 2020
@tk0miya tk0miya mentioned this pull request Apr 27, 2020
Closed
@tk0miya tk0miya force-pushed the 7068_pyproperty_directive branch 4 times, most recently from 043e5c0 to c04616d Compare April 29, 2020 05:51
@tk0miya tk0miya modified the milestones: 3.0.0, 3.1.0 Apr 29, 2020
eric-wieser
eric-wieser reviewed Apr 29, 2020
View reviewed changes
eric-wieser
eric-wieser reviewed Apr 29, 2020
View reviewed changes
@tk0miya tk0miya modified the milestones: 3.1.0, 3.2.0 May 23, 2020
@tk0miya tk0miya modified the milestones: 3.2.0, 3.3.0 Jul 18, 2020
@tk0miya tk0miya mentioned this pull request Aug 21, 2020
Closed
@tk0miya tk0miya modified the milestones: 3.3.0, 3.4.0 Oct 3, 2020
@tk0miya tk0miya modified the milestones: 3.4.0, 3.5.0 Dec 19, 2020
@tk0miya tk0miya force-pushed the 7068_pyproperty_directive branch from b28e3ed to a805eac Compare December 27, 2020 06:02
@tk0miya tk0miya modified the milestones: 3.5.0, 4.0.0 Feb 4, 2021
@tk0miya tk0miya changed the base branch from 3.x to master March 4, 2021 15:41
@tk0miya tk0miya force-pushed the 7068_pyproperty_directive branch 5 times, most recently from 0db271f to 722ae45 Compare March 5, 2021 16:15
@tk0miya
Copy link
Copy Markdown
Member Author

tk0miya commented Mar 5, 2021

Finally, I determined to drop the py:prop role because I felt tired to discuss more.

eric-wieser
eric-wieser reviewed Mar 5, 2021
View reviewed changes
@tk0miya tk0miya force-pushed the 7068_pyproperty_directive branch 2 times, most recently from 1815c1f to aac151c Compare March 5, 2021 16:39
tk0miya
tk0miya commented Mar 5, 2021
View reviewed changes
eric-wieser
eric-wieser reviewed Mar 5, 2021
View reviewed changes
@tk0miya tk0miya force-pushed the 7068_pyproperty_directive branch from aac151c to 204f86f Compare March 10, 2021 16:56
@tk0miya tk0miya merged commit 17bb789 into sphinx-doc:master Mar 13, 2021
@tk0miya
Copy link
Copy Markdown
Member Author

tk0miya commented Mar 13, 2021

Merged. Thank you for your comments!

@tk0miya tk0miya deleted the 7068_pyproperty_directive branch March 13, 2021 12:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@flying-sheep flying-sheep flying-sheep left review comments

@eric-wieser eric-wieser eric-wieser left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

domains:py internals:refactoring type:enhancement enhance or introduce a new feature

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tk0miya @flying-sheep @eric-wieser