c domain: Generate node_id for objects in the right way#7269
Merged
tk0miya merged 1 commit intosphinx-doc:3.xfrom Mar 14, 2020
Merged
c domain: Generate node_id for objects in the right way#7269tk0miya merged 1 commit intosphinx-doc:3.xfrom
tk0miya merged 1 commit intosphinx-doc:3.xfrom
Conversation
tk0miya
commented
Mar 7, 2020
| # by a module name and so easily clash with e.g. section titles | ||
| targetname = 'c.' + name | ||
| if targetname not in self.state.document.ids: | ||
| signode['names'].append(targetname) |
Member
Author
There was a problem hiding this comment.
I think mention in CHANGES is not needed for C domain. Because it might be not official and hidden feature.
.. c:function:: func
ref with `c.func`_
Member
Author
Codecov Report
@@ Coverage Diff @@
## 3.x #7269 +/- ##
==========================================
+ Coverage 84.05% 84.08% +0.02%
==========================================
Files 279 280 +1
Lines 43222 43256 +34
Branches 6299 6299
==========================================
+ Hits 36329 36370 +41
+ Misses 5520 5515 -5
+ Partials 1373 1371 -2
Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose