Skip to content

Use sphinx._cli.util.colour in sphinx.util.console#13241

Merged
AA-Turner merged 2 commits intosphinx-doc:masterfrom
AA-Turner:cleanup/util-console
Jan 16, 2025
Merged

Use sphinx._cli.util.colour in sphinx.util.console#13241
AA-Turner merged 2 commits intosphinx-doc:masterfrom
AA-Turner:cleanup/util-console

Conversation

@AA-Turner
Copy link
Copy Markdown
Member

No description provided.

@AA-Turner AA-Turner added this to the 8.2.0 milestone Jan 14, 2025
@AA-Turner AA-Turner merged commit a56fdad into sphinx-doc:master Jan 16, 2025
@AA-Turner AA-Turner deleted the cleanup/util-console branch January 16, 2025 16:57
@lucyleeow
Copy link
Copy Markdown

lucyleeow commented Jan 21, 2025

Just a question, have the old colours from sphinx.util.console now moved to the private sphinx._cli.util.colour? Does this mean we should stop using them?

ref: failing CI with sphinx dev workflow: sphinx-gallery/sphinx-gallery#1423

@AA-Turner
Copy link
Copy Markdown
Member Author

have the old colours from sphinx.util.console now moved to the private sphinx._cli.util.colour? Does this mean we should stop using them?

Everything should be re-exported from sphinx.util.console -- this was meant to be an internal-only change. All the b functions were missing though (black, blink, blue, bold, brown), which is fixed in 68cbf4e. Thank you for reporting!

A

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants