Use method colour key in the Builder API graph#12998
Merged
AA-Turner merged 7 commits intosphinx-doc:masterfrom Oct 11, 2024
Merged
Use method colour key in the Builder API graph#12998AA-Turner merged 7 commits intosphinx-doc:masterfrom
AA-Turner merged 7 commits intosphinx-doc:masterfrom
Conversation
…ell/sphinx into color-builder-graphviz
timhoffm
reviewed
Oct 11, 2024
timhoffm
reviewed
Oct 11, 2024
picnixz
reviewed
Oct 11, 2024
timhoffm
approved these changes
Oct 11, 2024
Contributor
timhoffm
left a comment
There was a problem hiding this comment.
Looks good. But the colors are not yet changed. Did you forget to push that?
picnixz
approved these changes
Oct 11, 2024
Member
picnixz
left a comment
There was a problem hiding this comment.
A last question, otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To show which methods are final/overridable/abstract: https://sphinx--12998.org.readthedocs.build/en/12998/extdev/builderapi.html