Allow --pdb option to also debug warnings#12727
Closed
jbms wants to merge 1 commit intosphinx-doc:masterfrom
Closed
Allow --pdb option to also debug warnings#12727jbms wants to merge 1 commit intosphinx-doc:masterfrom
jbms wants to merge 1 commit intosphinx-doc:masterfrom
Conversation
11e1a85 to
de19354
Compare
picnixz
reviewed
Aug 5, 2024
Member
picnixz
left a comment
There was a problem hiding this comment.
Could we have some tests? or is it too hard to test and mock pdb?
de19354 to
9954c49
Compare
Contributor
Author
Added a test. |
picnixz
reviewed
Aug 6, 2024
9954c49 to
ed86a6e
Compare
Previously, warnings emitted during reading and writing were deferred, which made --pdb ineffective for debugging them. With this change, warnings are no longer deferred when --pdb and --fail-on-warning are both specified.
ed86a6e to
b318a66
Compare
Member
|
Closing, as I believe that this is covered by #12743. Happy to reopen if I'm wrong, though. A |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
Previously, warnings emitted during reading and writing were deferred, which made --pdb ineffective for debugging them.
With this change, warnings are no longer deferred when --pdb and --fail-on-warning are both specified.