Skip to content

Avoid redundant target-version #12250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DimitriPapadopoulos wants to merge 1 commit into from
Closed

Avoid redundant target-version #12250

DimitriPapadopoulos wants to merge 1 commit into from

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Apr 9, 2024

Subject: Avoid redundant target-version

Feature or Bugfix

  • Refactoring

Purpose

  • Do not specify the minimal Python version with target-version. Instead, let ruff read requires-python in pyproject.toml.

@DimitriPapadopoulos
Avoid redundant target-version
c93266b 
Do not specify the minimal Python version with `target-version`. Instead,
let ruff read  `requires-python` in `pyproject.toml`.
@DimitriPapadopoulos DimitriPapadopoulos changed the title Avoid redudant target-version Avoid redundant target-version Apr 9, 2024
@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Apr 9, 2024

Just noticed it is flagged by repo-review:
https://learn.scientific-python.org/development/guides/repo-review/?repo=sphinx-doc%2Fsphinx&branch=master

RF002: Target version must be set

You have both Ruff's target-version and project.requires-python. You only need the later.

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Apr 9, 2024 •
edited
Loading

Unfortunately, there's a gap between theory and practice: I presume ruff may not read requires-python = ">=3.9" from pyproject.toml if there's a .ruff.toml file. I'll investigate and create an issue against ruff.

@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Apr 9, 2024
Closed
@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Apr 9, 2024

astral-sh/ruff#10299 already raised this ruff issue.

@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Apr 9, 2024
Closed
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft April 9, 2024 19:52
@AA-Turner AA-Turner closed this Apr 24, 2024
@DimitriPapadopoulos DimitriPapadopoulos deleted the no_target-version branch April 25, 2024 10:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DimitriPapadopoulos @AA-Turner