Normalize name for 'std:label' when loading inventory#12009
Closed
goerz wants to merge 1 commit intosphinx-doc:masterfrom
Closed
Normalize name for 'std:label' when loading inventory#12009goerz wants to merge 1 commit intosphinx-doc:masterfrom
name for 'std:label' when loading inventory#12009goerz wants to merge 1 commit intosphinx-doc:masterfrom
Conversation
Contributor
Author
|
I'm still going to add a test for this |
2487f0b to
250400f
Compare
Lowercase the `name` for any inventory item of type `std:label` to match the lowercaseing of `ref` and `numeref` references in the `std` domain.
250400f to
42f7bc2
Compare
Contributor
Author
|
Added the test, so this should be ready for review and merging. |
jayaddison
reviewed
Feb 27, 2024
Contributor
|
Closing; as I understand from the linked issue that we're going to take a different approach to solve the problem. |
Contributor
Author
|
Yup, I'll get back to you. A little busy with work right now, but I'll try to get the other PR in over the weekend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowercase the
namefor any inventory item of typestd:labelto match the lowercaseing ofrefandnumerefreferences in thestddomain.Closes #12008