Skip to content

Linkcheck crashes in 3.4.0 #8565

@nijel

Description

@nijel

Describe the bug

When running linkcheck in Weblate docs, it crashes with:

 Exception in thread Thread-2:
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/threading.py", line 932, in _bootstrap_inner

Exception occurred:
    self.run()
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/sphinx/builders/linkcheck.py", line 298, in check_thread
    self.wqueue.task_done()
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/queue.py", line 74, in task_done
Error:     raise ValueError('task_done() called too many times')
ValueError: task_done() called too many times
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/queue.py", line 233, in _put
    heappush(self.queue, item)
TypeError: '<' not supported between instances of 'int' and 'NoneType'

To Reproduce
Steps to reproduce the behavior:

<Paste your command-line here which cause the problem>

$ git clone https://github.com/WeblateOrg/weblate.git
$ cd weblate
$ pip install -r docs/requirements.txt
$ cd docs
$ make linkcheck

Expected behavior
No crash :-)

Your project
https://github.com/WeblateOrg/weblate/tree/master/docs

Screenshots
CI failure: https://github.com/WeblateOrg/weblate/runs/1585580811?check_suite_focus=true

Environment info

  • OS: Linux
  • Python version: 3.8.6
  • Sphinx version: 3.4.0
  • Sphinx extensions: several, but should not be relevant here
  • Extra tools: none involved

Additional context
Add any other context about the problem here.

  • [e.g. URL or Ticket]

Metadata

Metadata

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions