Fix for "Don't put an underline on linked images"#125
Merged
AA-Turner merged 2 commits intosphinx-doc:masterfrom Jul 15, 2024
Merged
Fix for "Don't put an underline on linked images"#125AA-Turner merged 2 commits intosphinx-doc:masterfrom
AA-Turner merged 2 commits intosphinx-doc:masterfrom
Conversation
The changes in bb5dbf and 585c08 to clear the bottom border are immediately getting overridden by the styles right below. Swap the order so these styles are applied as intended.
Contributor
Author
|
ping @bitprophet, this should be a quick review |
Contributor
Author
|
@bitprophet Any reason not to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in bb5dbf9 and 585c081 to clear the bottom border are getting overridden by the styles applied immediately below. (Was this ever working?)
Here is a fresh screenshot from http://docs.python-requests.org/ (a prominent Alabaster consumer) showing the underline on the license badge while hovering over it:
(my cursor got hidden by the screenshot, but it was hovering right over the license badge)
Swapping the order of these rules results in the styles getting applied as intended.
Thanks in advance for taking a look and thanks for the great work on Alabaster!