Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.69%. Comparing base (bbb4f1e) to head (86566c4).
⚠️ Report is 666 commits behind head on develop.

@@           Coverage Diff            @@
##           develop     #242   +/-   ##
========================================
  Coverage    85.69%   85.69%           
========================================
  Files           23       23           
  Lines         6069     6069           
========================================
  Hits          5201     5201           
  Misses         868      868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Since users in C and Fortran may be exclusive, I attempted to change directory structure and the names.

c-example/   # renamed from example/
fortran/example/  # new directory

Dependency of CMakeLists.txt files should be broken though I don't check it. Since I am afraid of conflict to modify that in upper directories, I just let it mostly unchanged.

It is done except for CMakeLists.txt files.

Since users in C and Fortran may be exclusive, I attempted to change directory structure and the names.

c-example/   # renamed from example/
fortran/example/  # new directory

I agree with that, but can it be structured like:

|-- example
  |-- c_api
  |-- fortran_api
  |-- python_api

Dependency of CMakeLists.txt files should be broken though I don't check it. Since I am afraid of conflict to modify that in upper directories, I just let it mostly unchanged.

I'll look into that. Just re-request a review to ping me when you want me to look into it.

Almost done. One final thing though, why not the following folder structure:

|-- example
  |-- c_api
  |-- fortran_api
  |-- python_api

(/example/c_api, etc.)

Top example readme tells about what common minimal example is implemented in all 3 and that a complete one is also provided.

Ok, my final note, fortran files should be F90 instead of f90. It's related to how they read macros and everything. It's a good standard to use.

CI fails because CMakeLists.txts are not updated properly due to the change of directory structure and maybe f90 to F90. I think this is better treated in another PR after merging this PR and expect @LecrisUT's help.

Please rebase onto develop. We cannot merge because of merge conflict.

$ git rebase origin/develop
$ git status
Check which files are conflicting and how to resolve it
$ emacs example/c_api/README.md
Command may be different because file was moved
Resolve conflicts by editting the blocks:
<<<<< HEAD
Content from origin/develop
=====
Content from branch examples
>>>>>
$ git rebase --continue

I can also recommend gitkraken if you don't feel comfortable with the git cli for this.

I will add commit fixes on top of this PR before merging when you feel it is ready.

Please rebase onto develop. We cannot merge because of merge conflict.

Thanks for your detailed instruction. No conflict was found in rebase.

Great. Pre-commit seems to fail

Oh, the merge is reporting changes from develop. A rebase would have made it cleaner to review.

Oh, the merge is reporting changes from develop. A rebase would have made it cleaner to review.

How can I do?

Oh, the merge is reporting changes from develop. A rebase would have made it cleaner to review.

How can I do?

At this point will have to interactively rebase to drop the merge commit. But basically running git rebase instead of git merge.

I'll handle that later

At this point will have to interactively rebase to drop the merge commit. But basically running git rebase instead of git merge.

I made git rebase but when I wanted to push, git said I need to pull, and I did it with the merge way. Probably my last choice was wrong. What could I do in this case? I should force-push?

https://github.com/atztogo/spglib/blob/4d66a9c249bbc96154585a01372ac8e82e41fa96/fortran/CMakeLists.txt#L2

Edit the file extension in the cmake files also.

I made git rebase but when I wanted to push, git said I need to pull, and I did it with the merge way. Probably my last choice was wrong. What could I do in this case? I should force-push?

Yes, you can freely force-push in these situations. Just never force-push the develop branch.

Edit the file extension in the cmake files also.

Yes, I made it. e2a01d5.

Is there anything left to do?

Just to fix git history and cmake. I'll do that tomorrow

Just to fix git history and cmake. I'll do that tomorrow

It is clearly difficult for me to do. Thanks @LecrisUT.

Could you make some changes there, and if possible add some words to example/README.md?

Thank you for pointing it out. I did it at ddcc153 and 86566c4.

I have no objection. Please merge if you are ready.

Thanks @LecrisUT and @lan496!