Skip to content

Change installation location of spglib_f08.mod#224

Closed
atztogo wants to merge 2 commits intospglib:developfrom
atztogo:fortran-mod-install-directory
Closed

Change installation location of spglib_f08.mod#224
atztogo wants to merge 2 commits intospglib:developfrom
atztogo:fortran-mod-install-directory

Conversation

@atztogo
Copy link
Copy Markdown
Collaborator

@atztogo atztogo commented Jan 27, 2023

I think .mod file of fortran should be put in include directory when installing.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 27, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.34%. Comparing base (aee574d) to head (8d9e6ba).
⚠️ Report is 723 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #224   +/-   ##
========================================
  Coverage    93.34%   93.34%           
========================================
  Files           15       15           
  Lines          902      902           
========================================
  Hits           842      842           
  Misses          60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LecrisUT
Copy link
Copy Markdown
Collaborator

Seems reasonable since it is used with a -I flag.

Also need to fix in:

Cflags: -I${prefix}/include -I${prefix}/@CMAKE_INSTALL_LIBDIR@

and
"$<INSTALL_INTERFACE:${CMAKE_INSTALL_LIBDIR}>")

@LecrisUT
Copy link
Copy Markdown
Collaborator

Also, we don't have tests for

  • fortran function calls
  • package install imports.

First one should be possible in the ctest. Not sure about a standard to do the latter.

@atztogo
Copy link
Copy Markdown
Collaborator Author

atztogo commented Jan 28, 2023

Thanks @LecrisUT!

Also need to fix in:

I included your fixes although I don't understand them :).

Also, we don't have tests for

I am looking at how to write fortran tests using ctest. I put it in an issue #225.

  • package install imports.

I have really no idea on this...

@atztogo
Copy link
Copy Markdown
Collaborator Author

atztogo commented Feb 3, 2023

I will close this PR because what was aimed was achieved by #226.

@atztogo atztogo closed this Feb 3, 2023
@atztogo atztogo deleted the fortran-mod-install-directory branch February 4, 2023 01:42
@LecrisUT LecrisUT added this to the 2.1 milestone Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants