Change installation location of spglib_f08.mod#224
Closed
atztogo wants to merge 2 commits intospglib:developfrom
atztogo:fortran-mod-install-directory
Closed
Change installation location of spglib_f08.mod#224atztogo wants to merge 2 commits intospglib:developfrom atztogo:fortran-mod-install-directory
atztogo wants to merge 2 commits intospglib:developfrom
atztogo:fortran-mod-install-directory
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #224 +/- ##
========================================
Coverage 93.34% 93.34%
========================================
Files 15 15
Lines 902 902
========================================
Hits 842 842
Misses 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Seems reasonable since it is used with a Also need to fix in: spglib/fortran/spglib_f08.pc.in Line 8 in aee574d and Line 17 in aee574d |
Collaborator
|
Also, we don't have tests for
First one should be possible in the |
Collaborator
Author
Collaborator
Author
|
I will close this PR because what was aimed was achieved by #226. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think
.modfile of fortran should be put inincludedirectory when installing.